[U-Boot] [PATCH] armv8: layerscape platform pcie link up state judgment strongly

Xiaowei Bao xiaowei.bao at nxp.com
Tue Aug 15 10:05:43 UTC 2017


Hi York,

I have add the inline comment in the new patch and have sent to you, please review it.

Thanks

-----Original Message-----
From: Xiaowei Bao 
Sent: Friday, August 11, 2017 9:39 AM
To: York Sun <york.sun at nxp.com>; u-boot at lists.denx.de; Priyanka Jain <priyanka.jain at nxp.com>; Z.q. Hou <zhiqiang.hou at nxp.com>; M.h. Lian <minghuan.lian at nxp.com>; sjg at chromium.org
Subject: RE: [PATCH] armv8: layerscape platform pcie link up state judgment strongly

Hi York,

I will add the inline comment in the patch, send it to you later.

thanks

-----Original Message-----
From: York Sun 
Sent: Wednesday, August 09, 2017 12:14 AM
To: Xiaowei Bao <xiaowei.bao at nxp.com>; u-boot at lists.denx.de; Priyanka Jain <priyanka.jain at nxp.com>; Z.q. Hou <zhiqiang.hou at nxp.com>; M.h. Lian <minghuan.lian at nxp.com>; sjg at chromium.org
Subject: Re: [PATCH] armv8: layerscape platform pcie link up state judgment strongly

On 08/07/2017 11:56 PM, Xiaowei Bao wrote:
> Hi York,
> 
> I will pay attention to the case of the case in commit message.
> 
> This patch is for some special reset times for longer pcie devices, in this case, the pcie device may on polling compliance state, the RC considers the pcie device is link up, but the pcie device is not link up, only the L0 state is link up state. So add the link up status judgement mechanisms.
> 
> About 100ms timeout, the pcie spec does not specify the link up timeout time, and the link up state is determined by a state machine. The state machine implementation is relatively complex, refer to uboot of other platform pcie link up state to determine the realization of the mechanism, we evaluated a timeout, in detect state consider the pcie device is link down, in L0 state consider the pcie device is link up, within  100ms in other states can be restored to the L0 state considers the pcie device is link up .

Can you put this information to inline comment? It will help us when we read the code later.

Thanks.

York


More information about the U-Boot mailing list