[U-Boot] [PATCH 2/3] env: Allow env_load() to detect errors

Simon Glass sjg at chromium.org
Sun Aug 20 10:45:14 UTC 2017


Now that we have errors available in the environment driver's load()
method, check the return valid.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 env/env.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/env/env.c b/env/env.c
index 8671f13f8d..1255d57f48 100644
--- a/env/env.c
+++ b/env/env.c
@@ -98,7 +98,7 @@ int env_load(void)
 		return -ENODEV;
 	if (!drv->load)
 		return 0;
-	drv->load();  /* TODO(sjg at chromium.org): Make this return an error */
+	ret = drv->load();
 	if (ret) {
 		debug("%s: Environment failed to load (err=%d)\n", __func__,
 		      ret);
-- 
2.14.1.480.gb18f417b89-goog



More information about the U-Boot mailing list