[U-Boot] [PATCH] env: Correct case of no sub-init function

Simon Glass sjg at chromium.org
Sun Aug 20 10:46:24 UTC 2017


On 19 August 2017 at 20:27, Tom Rini <trini at konsulko.com> wrote:
>
> With the change to the environment code to remove the common init stage
> of pointing to the default environment and setting it as valid, combined
> with the change to switch gd->env_valid from 0/1/2 to an enum we now
> must set env_valid to one of the enum values rather than an int.  And in
> this case, not only was setting it to an int wrong, it was now the wrong
> value.
>
> Fixes: 7938822a6b75 ("env: Drop common init() functions")
> Reported-by: Marek Vasut <marek.vasut at gmail.com>
> Reported-by: Andy Shevchenko <andy.shevchenko at gmail.com>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>  env/env.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

(I sent a similar patch just now after my build completed, but please ignore it)


More information about the U-Boot mailing list