[U-Boot] [PATCH 2/2] net: nfs: Correct type of rpc_t->u.reply->data

Joe Hershberger joe.hershberger at ni.com
Tue Aug 22 19:02:35 UTC 2017


On Sun, Aug 20, 2017 at 9:40 PM, Tom Rini <trini at konsulko.com> wrote:
> In rpc_t we declare data to be a uint8_t of size 2048, for a final size
> of 2048.  We also however declare the reply part of the union to have a
> uint32_t data field of NFS_READ_SIZE (1024) for a final size of
> 4096+24=4120 and an overrun.  Expand the comment above the struct to
> note that if NFS_READ_SIZE is increased then the data buf must also be
> increased and correct the declaration to be uint8_t.
>
> Reported-by: Coverity (CID: 152888)
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Signed-off-by: Tom Rini <trini at konsulko.com>

Acked-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list