[U-Boot] [PATCH 1/4] Revert "serial: ns16550: Add RX interrupt buffer support"

Bin Meng bmeng.cn at gmail.com
Thu Aug 24 03:17:38 UTC 2017


On Thu, Aug 17, 2017 at 3:11 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
> On Wed, Aug 16, 2017 at 11:37 PM, Stefan Roese <sr at denx.de> wrote:
>> This reverts commit 6822cf3ec7c8768b8727573b8f4b2cb3d870b881.
>>
>> As Bin Meng has tested and pointed out, we don't need the RX interrupt
>> for the RX buffer support at all. Just reading all available characters
>> into a buffer is sufficient to solve the problem with the dropped
>> characters upon long lines pasted into the U-Boot prompt. Since this
>> RX buffer support can be implemented in a generic way, without any
>> device specifica (e.g. for the ns16550), I'll post a new patch with
>> a new serial RX buffer support for DM, which all DM based serial
>> drivers can use.
>>
>> Signed-off-by: Stefan Roese <sr at denx.de>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Bin Meng <bmeng.cn at gmail.com>
>> Cc: Tom Rini <trini at konsulko.com>
>> ---
>>  drivers/serial/Kconfig   |  10 ----
>>  drivers/serial/ns16550.c | 123 ++---------------------------------------------
>>  include/ns16550.h        |  10 ----
>>  3 files changed, 5 insertions(+), 138 deletions(-)
>>
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

applied to u-boot-x86, thanks!


More information about the U-Boot mailing list