[U-Boot] [PATCH] libfdt: Initialize the stack variable

[Tom Rini]

On Thu, Aug 24, 2017 at 01:53:57PM +0800, tien.fong.chee at intel.com wrote:

> From: Tien Fong Chee <tien.fong.chee at intel.com>
> 
> Report Coverity log:
> The code uses a variable that has not
> been initialized, leading to unpredictable
> or unintended results.
> 
> Signed-off-by: Tien Fong Chee <tien.fong.chee at intel.com>
> ---
>  lib/libfdt/fdt_wip.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/libfdt/fdt_wip.c b/lib/libfdt/fdt_wip.c
> index 45fb964..01adad0 100644
> --- a/lib/libfdt/fdt_wip.c
> +++ b/lib/libfdt/fdt_wip.c
> @@ -115,7 +115,7 @@ int fdt_find_regions(const void *fdt, char * const inc[], int inc_count,
>  		     struct fdt_region region[], int max_regions,
>  		     char *path, int path_len, int add_string_tab)
>  {
> -	int stack[FDT_MAX_DEPTH];
> +	int stack[FDT_MAX_DEPTH] = { 0 };
>  	char *end;
>  	int nextoffset = 0;
>  	uint32_t tag;

Since this comes from libfdt, have you checked there as well?  And in
general, we use a Reported-by: Coverity (CID: xxxx) for issues.  BTW, if
you would like access to the community version of Coverity, please sign
up at https://scan.coverity.com/projects/das-u-boot?tab=overview thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170824/f831b64e/attachment.sig>