[U-Boot] rk3xxx.dtsi /usb_host missing specific compatible

Philipp Tomsich philipp.tomsich at theobroma-systems.com
Fri Aug 25 11:20:47 UTC 2017


+ Heiko

On Wed, 23 Aug 2017, Artturi Alm wrote:

> Hi,
>
>
> no idea if this is the right place to mail about this, but i got
> suggested this node is out-of-norm, and the diff below fixes that
> for me on rk3188.
>
> -Artturi

When submitting changes, please send a patch w/ an appropriate commit 
message (e.g. using patman).  If you tag it as "rockchip:", it will 
eventually get assigned to my queue.

>
> diff --git a/arch/arm/dts/rk3xxx.dtsi b/arch/arm/dts/rk3xxx.dtsi
> index 6d9e36d235..21f2afc104 100644
> --- a/arch/arm/dts/rk3xxx.dtsi
> +++ b/arch/arm/dts/rk3xxx.dtsi
> @@ -157,7 +157,7 @@
> 	};
>
> 	usb_host: usb at 101c0000 {
> -		compatible = "snps,dwc2";
> +		compatible = "rockchip,rk3066-usb", "snps,dwc2";

This is the same on the Linux upstream, which is the leading repository
for this DTS file.  Also, the "rockchip,rk3066-usb" is used by none of the 
drivers (whereas "snsp,dwc2" is matche by drivers/usb/host/dwc2.c.

>From my point of view, there's no point in changing this (unless Heiko 
would like to see this changed both here and in Linux).

> 		reg = <0x101c0000 0x40000>;
> 		interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> 		clocks = <&cru HCLK_OTG1>;
>


More information about the U-Boot mailing list