[U-Boot] [PATCH v2 4/4] rockchip: enable rockusb for all rockchip SoCs

[Łukasz Majewski]

Dear All,

> Hi Philipp, Andy, Tom
>>
>>> On 25 Aug 2017, at 03:51, Andy Yan <andyshrk at gmail.com> wrote:
>>>
>>> Hi Lukasz:
>>>
>>> 2017-08-22 18:05 GMT+08:00 Łukasz Majewski <lukma at denx.de
>>> <mailto:lukma at denx.de>>:
>>> Hi Kever,
>>>
>>>
>>> Philipp,
>>>
>>>     I have no idea about the status of rockusb, it has been a long time
>>> on the list.
>>>
>>> Maybe Eddie or Lukasz have an answer?
>>>
>>> I've asked Eddie to fix issues with breaking other boards when
>>> enabling USB gadget infrastructure on RK.
>>>
>>> No reply since then.
>>>
>>>
>>>
>>> Eddie has fix all the issues he can reproduced on local。 The only
>>> problem now is that  the rk3036 based boards(evb-rk3036/kylin-rk3036)
>>> show compile errors on CI[0],
>>
>> The Travis log shows linker errors for some of the other boards (i.e.
>> not evb-rk3036/kylin-rk3036), due to unresolved symbols.
>
> Yes, Indeed.
>
> I've build those boards locally with gcc 6.3 and it was successful.

And in the meantime - I would like to kindly ask Eddie to rebase this 
patch series on the newest u-boot-usb/master branch.

I will add the code to -dfu and submit a PR when new merge window opens.

Thanks in advance,
Łukasz

>
>
> Regarding travis CI:
>
> With Eddie's patches it shows error:
> https://travis-ci.org/lmajewski/u-boot-dfu/builds/268270904
>
> However, without Eddie's patches travis-CI doesn't show any errors:
> https://travis-ci.org/lmajewski/u-boot-dfu/builds/268303030
>
>
> Let's ask Tom (who has far more experience with travis-CI), if he saw
> something like that before.
>
>>
>>> but when we do the same compile on our local computer, the all
>>> evb-rk3036 and kylin-rk3036 compiled successfully. And we didn't find
>>> anything in Eddie's patch that will trigger such errors. As you
>>> mentationed in the mail[1], you have also build rk3036 successfully
>>> on your local. So maybe there is something different between the CI
>>> and the local build. Could you please give as some directions on this？
>>>
>>> [0] https://travis-ci.org/eddiecailinux/u-boot/jobs/235944449#L759
>>> <https://travis-ci.org/eddiecailinux/u-boot/jobs/235944449#L759>[1]
>>> http://patchwork.ozlabs.org/patch/766901/
>>> <http://patchwork.ozlabs.org/patch/766901/>
>>>
>>>
>>>
>>> I have to use those patches on my local branch, so that we don't have to
>>> enter
>>>
>>> bootrom mode for firmware update.
>>>
>>> Thanks,
>>> - Kever
>>> On 08/22/2017 04:44 PM, Dr. Philipp Tomsich wrote:
>>> Kever,
>>>
>>> I was about to apply the rockusb changes onto next yesterday, when I
>>> realised
>>> that rockusb hadn’t been merged on the USB side…
>>>
>>> Do you know the status on the rockusb patches?
>>> I’d like to avoid merging this on our end, before the infrastructure
>>> has been merged.
>>>
>>> Regards,
>>> Philipp.
>>>
>>> On 22 Aug 2017, at 09:35, Kever Yang <kever.yang at rock-chips.com
>>> <mailto:kever.yang at rock-chips.com>> wrote:
>>>
>>> Rockusb will be used by all the rockchip SoCs, enable it by
>>> default in Kconfig, and it can be work if USB gadget is available.
>>>
>>> Signed-off-by: Kever Yang <kever.yang at rock-chips.com
>>> <mailto:kever.yang at rock-chips.com>>
>>> Acked-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com
>>> <mailto:philipp.tomsich at theobroma-systems.com>>
>>> ---
>>>
>>> Changes in v2: None
>>>
>>> arch/arm/Kconfig | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>>> index da9324b..f566d50 100644
>>> --- a/arch/arm/Kconfig
>>> +++ b/arch/arm/Kconfig
>>> @@ -1084,6 +1084,8 @@ config ARCH_ROCKCHIP
>>>     select DM_PWM
>>>     select DM_REGULATOR
>>>     imply FAT_WRITE
>>> +    imply USB_FUNCTION_ROCKUSB
>>> +    imply CMD_ROCKUSB
>>>
>>> config TARGET_THUNDERX_88XX
>>>     bool "Support ThunderX 88xx"
>>> --
>>> 1.9.1
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> --
>>> Best regards,
>>>
>>> Lukasz Majewski
>>>
>>> --
>>>
>>> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
>>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
>>> Phone: (+49)-8142-66989-10 <tel:%28%2B49%29-8142-66989-10> Fax:
>>> (+49)-8142-66989-80 <tel:%28%2B49%29-8142-66989-80> Email: wd at denx.de
>>> <mailto:wd at denx.de>
>>>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot at lists.denx.de <mailto:U-Boot at lists.denx.de>
>>> https://lists.denx.de/listinfo/u-boot
>>> <https://lists.denx.de/listinfo/u-boot>
>>
>
>


-- 
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de