[U-Boot] [PATCH v2 03/10] fit: Introduce methods for applying overlays on fit-load

Simon Glass sjg at chromium.org
Sat Aug 26 13:36:57 UTC 2017


Hi,

On 11 August 2017 at 02:52, Pantelis Antoniou
<pantelis.antoniou at konsulko.com> wrote:
> Introduce an overlay based method for constructing a base DT blob
> to pass to the kernel.
>
> Both canned and runtime feature selection is supported.
>
> Signed-off-by: Pantelis Antoniou <pantelis.antoniou at konsulko.com>
> ---
>  common/image-fdt.c                           |   7 +-
>  common/image-fit.c                           | 216 ++++++++++++++++++++++++--
>  doc/uImage.FIT/command_syntax_extensions.txt |  12 +-
>  doc/uImage.FIT/overlay-fdt-boot.txt          | 221 +++++++++++++++++++++++++++
>  doc/uImage.FIT/source_file_format.txt        |   6 +-
>  include/image.h                              |  10 ++
>  6 files changed, 454 insertions(+), 18 deletions(-)
>  create mode 100644 doc/uImage.FIT/overlay-fdt-boot.txt

Can you please split this patch a bit?

I see changes to the existing code and some stuff inside an #ifdef.
Can you split out the refactoring from the new features?

Also please comment the functions you add to the header file.


More information about the U-Boot mailing list