[U-Boot] [PATCH 11/13] x86: braswell: Add FSP configuration

Simon Glass sjg at chromium.org
Sat Aug 26 22:39:50 UTC 2017


Hi Bin,

On 26 August 2017 at 07:56, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Sat, Aug 26, 2017 at 9:39 PM, Simon Glass <sjg at chromium.org> wrote:
>> On 15 August 2017 at 23:42, Bin Meng <bmeng.cn at gmail.com> wrote:
>>> Add FSP related configuration for Braswell.
>>>
>>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>> ---
>>>
>>>  arch/x86/cpu/braswell/Makefile                     |   2 +-
>>>  arch/x86/cpu/braswell/fsp_configs.c                | 158 ++++++++++++++
>>>  .../include/asm/arch-braswell/fsp/fsp_configs.h    |  89 ++++++++
>>>  arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h   | 172 +++++++++++++++
>>>  arch/x86/include/asm/arch-braswell/gpio.h          | 234 +++++++++++++++++++++
>>>  5 files changed, 654 insertions(+), 1 deletion(-)
>>>  create mode 100644 arch/x86/cpu/braswell/fsp_configs.c
>>>  create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_configs.h
>>>  create mode 100644 arch/x86/include/asm/arch-braswell/fsp/fsp_vpd.h
>>>  create mode 100644 arch/x86/include/asm/arch-braswell/gpio.h
>>>
>>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>> Can this use drivers instead of manual device-tree access?
>
> Which part?

Well you have intel,braswell-fsp for example. You could create a
driver with the two compatible strings and have it read the platdata
from the DT in the ofdata_to_platdata() method.

Regards,
Simon


More information about the U-Boot mailing list