[U-Boot] [PATCH 1/2] x86: ich-spi: Remove useless assignment in ich_spi_xfer()

Bin Meng bmeng.cn at gmail.com
Sun Aug 27 02:22:58 UTC 2017


In ich_spi_xfer() when the driver presets control fields, control
variable gets assigned twice. Apparently only the last assignment
takes effect. Remove the other one.

Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
---

 drivers/spi/ich.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/spi/ich.c b/drivers/spi/ich.c
index 373bc26..5a3d690 100644
--- a/drivers/spi/ich.c
+++ b/drivers/spi/ich.c
@@ -468,8 +468,6 @@ static int ich_spi_xfer(struct udevice *dev, unsigned int bitlen,
 	}
 
 	/* Preset control fields */
-	control = ich_readw(ctlr, ctlr->control);
-	control &= ~SSFC_RESERVED;
 	control = SPIC_SCGO | ((opcode_index & 0x07) << 4);
 
 	/* Issue atomic preop cycle if needed */
-- 
2.9.2



More information about the U-Boot mailing list