[U-Boot] [PATCH] bch: don't use __BSD_VISIBLE to test for fls

Jonathan Gray jsg at jsg.id.au
Sun Aug 27 10:45:14 UTC 2017


Commit 4ecc988301bc8e981e6d7538c57cdb3aa82f7c1d assumes fls is in libc
if __BSD_VISIBLE is defined.  This appears to only be true on FreeBSD
and DragonFlyBSD.  OpenBSD defines __BSD_VISIBLE and does not have fls
in strings.h/libc.

Switch the test for __BSD_VISIBLE to one for __DragonFly__ and
__FreeBSD__ to unbreak the build on OpenBSD.

Signed-off-by: Jonathan Gray <jsg at jsg.id.au>
---
 lib/bch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bch.c b/lib/bch.c
index 7a2d9d3b86..d0d7e25c4e 100644
--- a/lib/bch.c
+++ b/lib/bch.c
@@ -117,7 +117,7 @@ struct gf_poly_deg1 {
 };
 
 #ifdef USE_HOSTCC
-#ifndef __BSD_VISIBLE
+#if !defined(__DragonFly__) && !defined(__FreeBSD__)
 static int fls(int x)
 {
 	int r = 32;
-- 
2.14.1



More information about the U-Boot mailing list