[U-Boot] [PATCH v3] rpi: Enable USB keyboard support

Alexander Graf agraf at suse.de
Mon Aug 28 10:10:40 UTC 2017



> Am 26.08.2017 um 19:43 schrieb Simon Glass <sjg at chromium.org>:
> 
> This is currently disabled, so USB keyboards are not detected in U-Boot.
> Enable this option to fix that.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Tested-by: Jonathan Gray <jsg at jsg.id.au>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> Tested-by: Paul Barker <pbarker at toganlabs.com>

When did the default behavior on kbd usb support change? I'd be inclined to say that we should restore the exact same functionality scope as before for all affected boards, not just a few well tested ones ;).

In fact, wouldn't it make sense to imply usb kbd support in kconfig always when usb (and gfx?) is present?

That said, this patch itself is good either way, just maybe not reaching far enough ;).


Alex




More information about the U-Boot mailing list