[U-Boot] [PATCH v2] imx: imx7d: remove CamelCase from ENET_xMHz macros

Stefano Babic sbabic at denx.de
Thu Aug 31 18:20:13 UTC 2017


Hi Eric,

On 31/08/2017 17:34, Eric Nelson wrote:
> Update these macros to use all upper-case to avoid checkpatch
> warnings:
> 
> 	ENET_25MHz,
> 	ENET_50MHz,
> 	ENET_125MHz,
> 
> Signed-off-by: Eric Nelson <eric at nelint.com>
> ---
> V2 fixes a couple of references in mx7/clock.c
>  arch/arm/include/asm/arch-mx7/clock.h     | 6 +++---
>  arch/arm/mach-imx/mx7/clock.c             | 6 +++---
>  board/freescale/mx7dsabresd/mx7dsabresd.c | 2 +-
>  board/technexion/pico-imx7d/pico-imx7d.c  | 2 +-
>  board/toradex/colibri_imx7/colibri_imx7.c | 2 +-
>  5 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/include/asm/arch-mx7/clock.h b/arch/arm/include/asm/arch-mx7/clock.h
> index 688d236..3b115ad 100644
> --- a/arch/arm/include/asm/arch-mx7/clock.h
> +++ b/arch/arm/include/asm/arch-mx7/clock.h
> @@ -318,9 +318,9 @@ struct clk_root_map {
>  };
>  
>  enum enet_freq {
> -	ENET_25MHz,
> -	ENET_50MHz,
> -	ENET_125MHz,
> +	ENET_25MHZ,
> +	ENET_50MHZ,
> +	ENET_125MHZ,
>  };
>  
>  u32 get_root_clk(enum clk_root_index clock_id);
> diff --git a/arch/arm/mach-imx/mx7/clock.c b/arch/arm/mach-imx/mx7/clock.c
> index 2cfde46..8150faa 100644
> --- a/arch/arm/mach-imx/mx7/clock.c
> +++ b/arch/arm/mach-imx/mx7/clock.c
> @@ -966,15 +966,15 @@ int set_clk_enet(enum enet_freq type)
>  	clock_enable(CCGR_ENET2, 0);
>  
>  	switch (type) {
> -	case ENET_125MHz:
> +	case ENET_125MHZ:
>  		enet1_ref = ENET1_REF_CLK_ROOT_FROM_PLL_ENET_MAIN_125M_CLK;
>  		enet2_ref = ENET2_REF_CLK_ROOT_FROM_PLL_ENET_MAIN_125M_CLK;
>  		break;
> -	case ENET_50MHz:
> +	case ENET_50MHZ:
>  		enet1_ref = ENET1_REF_CLK_ROOT_FROM_PLL_ENET_MAIN_50M_CLK;
>  		enet2_ref = ENET2_REF_CLK_ROOT_FROM_PLL_ENET_MAIN_50M_CLK;
>  		break;
> -	case ENET_25MHz:
> +	case ENET_25MHZ:
>  		enet1_ref = ENET1_REF_CLK_ROOT_FROM_PLL_ENET_MAIN_25M_CLK;
>  		enet2_ref = ENET2_REF_CLK_ROOT_FROM_PLL_ENET_MAIN_25M_CLK;
>  		break;
> diff --git a/board/freescale/mx7dsabresd/mx7dsabresd.c b/board/freescale/mx7dsabresd/mx7dsabresd.c
> index a681ece..5819b18 100644
> --- a/board/freescale/mx7dsabresd/mx7dsabresd.c
> +++ b/board/freescale/mx7dsabresd/mx7dsabresd.c
> @@ -260,7 +260,7 @@ static int setup_fec(void)
>  		(IOMUXC_GPR_GPR1_GPR_ENET1_TX_CLK_SEL_MASK |
>  		 IOMUXC_GPR_GPR1_GPR_ENET1_CLK_DIR_MASK), 0);
>  
> -	return set_clk_enet(ENET_125MHz);
> +	return set_clk_enet(ENET_125MHZ);
>  }
>  
>  
> diff --git a/board/technexion/pico-imx7d/pico-imx7d.c b/board/technexion/pico-imx7d/pico-imx7d.c
> index b4c9be7..67bab51 100644
> --- a/board/technexion/pico-imx7d/pico-imx7d.c
> +++ b/board/technexion/pico-imx7d/pico-imx7d.c
> @@ -182,7 +182,7 @@ static int setup_fec(void)
>  			(IOMUXC_GPR_GPR1_GPR_ENET1_TX_CLK_SEL_MASK |
>  			IOMUXC_GPR_GPR1_GPR_ENET1_CLK_DIR_MASK), 0);
>  
> -	return set_clk_enet(ENET_125MHz);
> +	return set_clk_enet(ENET_125MHZ);
>  }
>  
>  int board_phy_config(struct phy_device *phydev)
> diff --git a/board/toradex/colibri_imx7/colibri_imx7.c b/board/toradex/colibri_imx7/colibri_imx7.c
> index 5cb14b4..13b2b57 100644
> --- a/board/toradex/colibri_imx7/colibri_imx7.c
> +++ b/board/toradex/colibri_imx7/colibri_imx7.c
> @@ -280,7 +280,7 @@ static int setup_fec(void)
>  			IOMUXC_GPR_GPR1_GPR_ENET1_TX_CLK_SEL_MASK);
>  #endif
>  
> -	return set_clk_enet(ENET_50MHz);
> +	return set_clk_enet(ENET_50MHZ);
>  }
>  
>  int board_phy_config(struct phy_device *phydev)
> 


Reviewed-by: Stefano Babic <sbabic at denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list