[U-Boot] EFI: incorrect device paths

[Heinrich Schuchardt]

On 11/25/2017 02:49 AM, Heinrich Schuchardt wrote:
> Hello Emmanuel,
> 
> yesterday you reported on the u-boot ICS channel that you saw an
> incorrect device path for the SD card on your BananaPi M2
> (/venHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/Usb(0x6,0x0)/HD(Part0,MBRType=01)).
> 
> 
> In dp_fill() both mass storage (UCLASS_MASS_STORAGE) and USB hubs
> (UCLASS_USB_HUB) are mapped to USB devices. Maybe that is what happened
> to you.

For CONFIG_BLK=n a fictitious USB node is created in the device path.
See function dp_part_fill().

Best regards

Heinrich

> 
> On my Odroid C2 the following devices paths are created:
> 
> Installed device path protocols:
> /MemoryMapped(0x0,0x7ff9c604,0x7ff9c604)
> /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/MMC(Slot0)/HD(Part0,Sig6fe30000)
> 
> 
> /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/MMC(Slot0)/HD(Part1,Sig6fe30000)
> 
> 
> /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/MMC(Slot0)/HD(Part2,Sig6fe30000)
> 
> 
> /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/MMC(Slot0)/HD(Part3,Sig6fe30000)
> 
> 
> /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/MMC(Slot0)
> 
> /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/
> /VenHw(dbca4c98-6cb0-694d-0872-819c650cbbb1)
> 
> /VenHw(dbca4c98-6cb0-694d-0872-819c650cbbb1)/
> VenHw(dbca4c98-6cb0-694d-0872-819c650cbba2)
> 
> /VenHw(dbca4c98-6cb0-694d-0872-819c650cbbb1)/
> VenHw(dbca4c98-6cb0-694d-0872-819c650cbba2)/VenHw(dbca4c9...
> 
> I have an SD card with four partitions.
> 
> The entry with partition number 0 should match to the whole disk. So
> obviously one device path is missing.
> 
> eMMC should be reported as eMMC(SlotNumber) where slot number is a
> number only, e.g. eMMC(1).
> 
> SD cards should be reported as SD(SlotNumber), e.g. SD(1).
> 
> Partions should be reported as
> HD(Partition,Type,Signature,Start,Size) or
> HD(Partition,Type,Signature) (display only)
> e.g.
> HD(1,GPT,15E39A00-1DD2-1000-8D7F-00A0C92408FC,0x22,0x271000)
> 
> So there seems to be still a lot to be fixed.
> 
> Best regards
> 
> Heinrich
>