[U-Boot] [PATCH v2] test: py: Add an option to skip sleep test

Stephen Warren swarren at wwwdotorg.org
Fri Dec 8 16:54:06 UTC 2017


On 12/08/2017 07:47 AM, Michal Simek wrote:
> Some QEMUs have a problem with time setup that's why
> sleep test is failing. Introduce env__sleep_accurate
> boardenv variable to have an option to skip sleep test.

Nit: Commit descriptions are typically wrapped around 70-74 characters; 
the above is very narrow.

> diff --git a/test/py/tests/test_sleep.py b/test/py/tests/test_sleep.py

> +"""
> +Note: This test doesn't rely on boardenv_* configuration values but they can
> +change test behavior.
> +
> +# Setup env__sleep_accurate to False if time is not accurate on your platform
> +env__sleep_accurate = False
> +
> +"""

Nit: No need for that trailing empty line in the docstring.

Reviewed-by: Stephen Warren <swarren at nvidia.com>

(I was going to contemplate a more generic system implemented in 
conftest.py that could work with any test, but I guess this is simple 
enough and solves the only issue we have right now, so it's fine.)


More information about the U-Boot mailing list