[U-Boot] [RESEND PATCH 1/2] dm: core: add missing dev_count_phandle_with_args()

Patrice CHOTARD patrice.chotard at st.com
Mon Dec 11 09:08:28 UTC 2017


Hi Joe

On 12/09/2017 08:28 PM, Joe Hershberger wrote:
> On Mon, Dec 4, 2017 at 2:05 AM, Patrice CHOTARD <patrice.chotard at st.com> wrote:
>> Hi Simon
>>
>> On 12/02/2017 04:28 AM, Simon Glass wrote:
>>> Hi Patrice,
>>>
>>> On 29 November 2017 at 01:06,  <patrice.chotard at st.com> wrote:
>>>> From: Patrice Chotard <patrice.chotard at st.com>
>>>>
>>>> Add missing dev_count_phandle_with_args() to avoid
>>>> compilation issue.
>>>>
>>>> Signed-off-by: Patrice Chotard <patrice.chotard at st.com>
>>>> ---
>>>>    drivers/core/read.c | 7 +++++++
>>>>    1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/drivers/core/read.c b/drivers/core/read.c
>>>> index 5d440ce..f346cc1 100644
>>>> --- a/drivers/core/read.c
>>>> +++ b/drivers/core/read.c
>>>> @@ -103,6 +103,13 @@ int dev_read_phandle_with_args(struct udevice *dev, const char *list_name,
>>>>                                                 out_args);
>>>>    }
>>>>
>>>> +int dev_count_phandle_with_args(struct udevice *dev, const char *list_name,
>>>> +                               const char *cells_name)
>>>
>>> Is there a declaration of this in the header file?
>>
>> yes
>>
> 
> It seems that the function is only defined if
> CONFIG_DM_DEV_READ_INLINE is defined. Otherwise, there is just a
> prototype, but no implementation in include/dm/read.h.

The implementation is located in include/dm/read.h line 499.

For information, it's needed to not break compilation for a few aarch64 
platforms (puma-rk3399 and lion-rk3368).

Patrice

> 
> Reviewed-by: Joe Hershberger <joe.hershberger at ni.com>
> 
>>
>>>
>>>> +{
>>>> +       return ofnode_count_phandle_with_args(dev_ofnode(dev), list_name,
>>>> +                                             cells_name);
>>>> +}
>>>> +
>>>>    int dev_read_addr_cells(struct udevice *dev)
>>>>    {
>>>>           return ofnode_read_addr_cells(dev_ofnode(dev));
>>>> --
>>>> 1.9.1
>>>>
>>>
>>> Regards,
>>> Simon
>>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> https://lists.denx.de/listinfo/u-boot


More information about the U-Boot mailing list