[U-Boot] [PATCH 01/16] power: sunxi: add AXP803 PMIC support

[Maxime Ripard]

On Tue, Dec 12, 2017 at 02:20:17PM +0530, Jagan Teki wrote:
> On Tue, Dec 12, 2017 at 1:28 PM, Maxime Ripard
> <maxime.ripard at free-electrons.com> wrote:
> > Hi,
> >
> > On Tue, Dec 12, 2017 at 12:28:16PM +0530, Jagan Teki wrote:
> >> AXP803 another PMIC produced by x-powers and paired with
> >> A64 via RSB bus.
> >>
> >> unlike other axp chip's support in SPL this is only added
> >> for U-Boot proper since SPL on A64 has no space to add anything.
> >
> > How do you setup the CPU and DRAM regulators then?
> >
> >> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>
> >> ---
> >>  arch/arm/mach-sunxi/Makefile   |   9 ++
> >>  arch/arm/mach-sunxi/pmic_bus.c |   9 +-
> >>  arch/arm/mach-sunxi/rsb.c      |   2 +-
> >>  board/sunxi/board.c            |  40 +++++++
> >>  drivers/power/Kconfig          |  95 ++++++++++-----
> >>  drivers/power/Makefile         |   3 +
> >>  drivers/power/axp803.c         | 260 +++++++++++++++++++++++++++++++++++++++++
> >>  include/axp803.h               |  68 +++++++++++
> >>  include/axp_pmic.h             |   4 +
> >>  9 files changed, 458 insertions(+), 32 deletions(-)
> >>  create mode 100644 drivers/power/axp803.c
> >>  create mode 100644 include/axp803.h
> >>
> >> diff --git a/arch/arm/mach-sunxi/Makefile b/arch/arm/mach-sunxi/Makefile
> >> index 2a3c379..aedf22f 100644
> >> --- a/arch/arm/mach-sunxi/Makefile
> >> +++ b/arch/arm/mach-sunxi/Makefile
> >> @@ -19,9 +19,15 @@ endif
> >>  obj-$(CONFIG_MACH_SUN6I)     += prcm.o
> >>  obj-$(CONFIG_MACH_SUN8I)     += prcm.o
> >>  obj-$(CONFIG_MACH_SUN9I)     += prcm.o
> >> +ifndef CONFIG_SPL_BUILD
> >> +obj-$(CONFIG_MACH_SUN50I)    += prcm.o
> >> +endif
> >
> > The number of lines here is starting to be a bit ridiculous, please
> > make a Kconfig option selected by the SoC families.
> 
> as of now there was no Kconfig option for prcm,

This is my point, you should add it :)

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171213/babcdb37/attachment.sig>