[U-Boot] [PATCH v3 1/2] drivers/misc: Share qbman init between archs

York Sun york.sun at nxp.com
Thu Dec 14 01:36:06 UTC 2017


On 12/11/2017 03:02 PM, Ahmed Mansour wrote:
> This patch adds changes necessary to move functionality present in
> PowerPC folders with ARM architectures that have DPAA1 QBMan hardware
> 
> - Create new board/freescale/common/fsl_portals.c to house shared
>   device tree fixups for DPAA1 devices with ARM and PowerPC cores
> - Add new header file to top includes directory to allow files in
>   both architectures to grab the function prototypes
> - Port inhibit_portals() from PowerPC to ARM. This function is used in
>   setup to disable interrupts on all QMan and BMan portals. It is
>   needed because the interrupts are enabled by default for all portals
>   including unused/uninitialised portals. When the kernel attempts to
>   go to deep sleep the unused portals prevent it from doing so
> 
> Signed-off-by: Ahmed Mansour <ahmed.mansour at nxp.com>
> 
> ---
> 
> Changes in v3:
> - Add freescale old copyright in new file since it is a modified copy
> - Add ifdef QBMAN guard around get_qman_freq()
> - Return freq_qman instead of freq_systembus. More readable and robust
> - Add white space before return line in get_qman_freq()
> 
> Changes in v2:
> - Add get_qman_freq() to replace get_sys_info() for readability
> - Correct the copyright year in new files
> - Replace !ARM with PPC to wall off PowerPC SOCs specific qman setup
> - Rename portals.c -> fsl_portals.c for clarity
> 
>  arch/arm/cpu/armv8/fsl-layerscape/cpu.c            |   4 +
>  arch/arm/cpu/armv8/fsl-layerscape/fdt.c            |   9 +
>  .../arm/cpu/armv8/fsl-layerscape/fsl_lsch2_speed.c |  14 +
>  .../include/asm/arch-fsl-layerscape/immap_lsch2.h  |  29 ++
>  arch/arm/include/asm/arch-fsl-layerscape/speed.h   |   3 +
>  arch/powerpc/cpu/mpc85xx/cpu_init.c                |   3 +-
>  arch/powerpc/cpu/mpc85xx/fdt.c                     |   1 +
>  arch/powerpc/cpu/mpc85xx/portals.c                 | 281 -------------------
>  arch/powerpc/include/asm/fsl_liodn.h               |   7 +-
>  arch/powerpc/include/asm/fsl_portals.h             |   4 -
>  arch/powerpc/include/asm/immap_85xx.h              |  60 ----
>  drivers/misc/Makefile                              |   1 +
>  drivers/misc/fsl_portals.c                         | 305 +++++++++++++++++++++
>  include/configs/ls1043a_common.h                   |   2 +
>  include/fsl_qbman.h                                |  75 +++++
>  15 files changed, 450 insertions(+), 348 deletions(-)
>  create mode 100644 drivers/misc/fsl_portals.c
>  create mode 100644 include/fsl_qbman.h

Ahmed,

This patch causes compiling error for P1023RDB Cyrus_P5020 kmlion1
kmcoge4 Cyrus_P5040. Please fix.

York


More information about the U-Boot mailing list