[U-Boot] [EXT] [PATCH] arm64: mvebu: armada-8k: support SD card environment

[Kostya Porotchkin]

> -----Original Message-----
> From: Baruch Siach [mailto:baruch at tkos.co.il]
> Sent: Sunday, December 10, 2017 13:54
> To: Stefan Roese
> Cc: u-boot at lists.denx.de; Sergey Matyukevich; Baruch Siach; Kostya
> Porotchkin
> Subject: [EXT] [PATCH] arm64: mvebu: armada-8k: support SD card
> environment
> 
> External Email
> 
> ----------------------------------------------------------------------
> Allow storing the environment on the Macchiatobin SD card. This is
> useful for distribution of SD card software images. Currently, the
> environment is always loaded from the SPI flash whose content might be
> incompatible with SD card kernel loading.
> 
> Use the last 64KB of the 32MB boot partition as per the instructions in
> the Macchiatobin wiki:
> 
>   http://wiki.macchiatobin.net/tiki-
> index.php?page=Setup+alternative+boot+sources
> 
> Cc: Konstantin Porotchkin <kostap at marvell.com>
> Signed-off-by: Baruch Siach <baruch at tkos.co.il>
> ---
>  include/configs/mvebu_armada-8k.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/configs/mvebu_armada-8k.h
> b/include/configs/mvebu_armada-8k.h
> index d85527434a0a..0457a72e353b 100644
> --- a/include/configs/mvebu_armada-8k.h
> +++ b/include/configs/mvebu_armada-8k.h
> @@ -73,7 +73,12 @@
>  #define CONFIG_SF_DEFAULT_MODE		SPI_MODE_0
>  #define CONFIG_ENV_SPI_MODE		CONFIG_SF_DEFAULT_MODE
> 
> +#if defined(CONFIG_ENV_IS_IN_SPI_FLASH)
>  #define CONFIG_ENV_OFFSET		0x180000 /* as Marvell U-Boot version */
> +#elif defined(CONFIG_ENV_IS_IN_MMC)
> +#define CONFIG_SYS_MMC_ENV_DEV		1
> +#define CONFIG_ENV_OFFSET		0x21f0000
> +#endif
[Konstantin Porotchkin] 
I think this will break boot from the on-board eMMC device.
Maybe the environment offset should be connected to the MMC device ID.
So it will be different for SD and eMMC.
The eMMC boot partition is not that big as the space on SD allocated for the boot images.
Additionally, the SD pre-allocated boot space is not really a constant value.

Kosta

>  #define CONFIG_ENV_SIZE			(64 << 10) /* 64KiB */
>  #define CONFIG_ENV_SECT_SIZE		(64 << 10) /* 64KiB sectors */
> 
> --
> 2.15.0