[U-Boot] [PATCH] common/memsize.c: restore content of the base address

[Wolfgang Denk]

Dear Patrick,

In message <10532397af3d416f9a1b30f0b09a94f1 at SFHDAG6NODE3.st.com> you wrote:
> 
> > You should keep the functionality, but move it to where it belongs, i. e. to the
> > SPL running from OCM.
> 
> I remove it in U-Boot and I call it only in SPL,
> executed in onchip RAM, juste after DDR controller initalisation
> 
> So for my board, I have no more issue with the function.

Can you please do me the favour and verify that with this change no
memmory corruption / modification happens?

> For the last case (return (maxsize)),
> when no overlap is detect, the content of base is not restored.
> So for me, the function get_ram_size is not safe for the DDR content.

What exactly do you mean by "overlap" here?

> Do you think, that I need to continue with the patchset,
> (I need a v2 to remove the uncessary restore in the second loop after code analysis)
> even it is no more usefull for me.
> 
> Or do you prefer that I drop the patchset to avoid regression ?

I would really like to finally find an explanation why this code is
(or has been) working well on so many boards, while on a few boards
this problem gets reported - and the supposed fix (which looks
reasonable when lookingon it) breaks other boards.

So I would really appreciate if you could continue to work on this.

Thanks!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The IQ of the group is the lowest IQ of a member of the group divided
by the number of people in the group.