[U-Boot] [PATCH V11 1/4] usb: rockchip: add the rockusb gadget

[Eddie Cai]

Hi Lukasz

2017-12-12 20:31 GMT+08:00 Lukasz Majewski <lukma at denx.de>:
> Hi Eddie,
>
>> On 12/01/2017 08:20 AM, Eddie Cai wrote:
>> > this patch implement rockusb protocol on the device side. this is
>> > based on USB download gadget infrastructure. the rockusb function
>> > implements the rd, wl, rid commands. it can work with rkdeveloptool
>> >
>> > Signed-off-by: Eddie Cai <eddie.cai.linux at gmail.com>
>> > Reviewed-by: Simon Glass <sjg at chromium.org>
>> > ---
>> > Changes in v11:
>> > -fix checkpatch error
>> > -add maintainer
>> >
>> > Changes in v10:
>> > -fix build error
>> >
>> > Changes in v9:
>> > -fix compile error
>> >
>> > Changes in v8:
>> > -none
>> >
>> > Changes in v7:
>> > -none
>> >
>> > Changes in v6:
>> > -move some data to f_rockusb structure
>> >
>> > Changes in v5:
>> > -fix build error when build non-rockchip board
>> > -fix checkpatch error
>> >
>> > Changes in v4:
>> > -use enum instead of macro define
>> > -move some structure define and macro to f_rockusb.h
>> > -add some function comment as Simon required
>> > -address other comment from Simon
>> > -fix build error as Lukasz point out
>> >
>> > ---
>> >  MAINTAINERS                                    |   5 +
>> >  arch/arm/include/asm/arch-rockchip/f_rockusb.h | 132 +++++
>> >  drivers/usb/gadget/Kconfig                     |   8 +
>> >  drivers/usb/gadget/Makefile                    |   1 +
>> >  drivers/usb/gadget/f_rockusb.c                 | 697
>> > +++++++++++++++++++++++++ 5 files changed, 843 insertions(+)
>> >  create mode 100644 arch/arm/include/asm/arch-rockchip/f_rockusb.h
>> >  create mode 100644 drivers/usb/gadget/f_rockusb.c
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 2a20b94..e92a15d 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -452,6 +452,11 @@ S:     Maintained
>> >  T: git git://git.denx.de/u-boot-usb.git
>> >  F: drivers/usb/
>> >
>> > +ROCKUSB
>> > +M: Eddie Cai <eddie.cai.linux at gmail.com>
>> > +S:      Maintained
>> > +F: drivers/usb/gadget/f_rockusb.c
>> > +
>> >  VIDEO
>> >  M: Anatolij Gustschin <agust at denx.de>
>> >  S: Maintained
>> > diff --git a/arch/arm/include/asm/arch-rockchip/f_rockusb.h
>> > b/arch/arm/include/asm/arch-rockchip/f_rockusb.h new file mode
>> > 100644 index 0000000..c207a78
>> > --- /dev/null
>> > +++ b/arch/arm/include/asm/arch-rockchip/f_rockusb.h
>> > @@ -0,0 +1,132 @@
>> > +/*
>> > + * (C) Copyright 2017
>> > + *
>> > + * Eddie Cai <eddie.cai.linux at gmail.com>
>> > + *
>> > + * SPDX-License-Identifier:        GPL-2.0+
>> > + */
>> > +
>> > +#ifndef _F_ROCKUSB_H_
>> > +#define _F_ROCKUSB_H_
>> > +#include <blk.h>
>> > +
>> > +#define ROCKUSB_VERSION            "0.1"
>> > +
>> > +#define ROCKUSB_INTERFACE_CLASS    0xff
>> > +#define ROCKUSB_INTERFACE_SUB_CLASS        0x06
>> > +#define ROCKUSB_INTERFACE_PROTOCOL 0x05
>> > +
>> > +#define RX_ENDPOINT_MAXIMUM_PACKET_SIZE_2_0  (0x0200)
>> > +#define RX_ENDPOINT_MAXIMUM_PACKET_SIZE_1_1  (0x0040)
>> > +#define TX_ENDPOINT_MAXIMUM_PACKET_SIZE      (0x0040)
>>
>> My V10 comments were not addressed, NAK.
>
> Do you plan to address Marek's comments and prepare next version ?
I just addressed all the comment and sent out V12 patches.
>
>>
>> Also, I'm not sure why you have 20 people on To: list , Cc would be
>> preferred and trimming the list down to only relevant people would
>> also be preferred.
>
>
>
> Best regards,
>
> Lukasz Majewski
>
> --
>
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de