[U-Boot] [U-Boot,v2] rockchip: update boot0 hook

Dr. Philipp Tomsich philipp.tomsich at theobroma-systems.com
Sun Dec 17 15:49:01 UTC 2017


Kever,

> On 15 Dec 2017, at 16:58, Philipp Tomsich <philipp.tomsich at theobroma-systems.com> wrote:
> 
>> Rockchip SoCs only need boot0 hook at SPL, and the U-Boot proper do not
>> need it.
>> 
>> The very beginning of U-Boot proper is different between armv7 and armv8:
>> armv7 start with ARM_VECTORS while armv8 start with 'b reset'.
>> 
>> Here is the map of very beginning for all cases:
>> armv7 SPL: TAG(overwrite 'b 1f')+'b reset' + ARM_VECTORS
>> armv7 U-Boot: ARM_VECTORS
>> armv8 SPL: TAG(overwrite 'b 1f')+'b reset' + Reserved_iram(rk3399)
>> armv8 U-Boot: 'b reset'
>> 
>> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
>> Acked-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>> ---
>> 
>> Changes in v2:
>> - update commit message
>> 
>> arch/arm/include/asm/arch-rockchip/boot0.h | 14 +++++++++-----
>> 1 file changed, 9 insertions(+), 5 deletions(-)
>> 
> 
> Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>

Changes requested are still pending from v1.
When starting to merge this, I encountered the same warnings and the nested
#if/#elif statements as last time...

None of the changes I had requested against v1 have been done.
Please refer to
	https://patchwork.ozlabs.org/patch/836639/

Please revise, so we can get this merged next week as we should get this fix
in as quickly as possible...

Thanks.
Philipp.



More information about the U-Boot mailing list