[U-Boot] [PATCH] config: Enable part command for socfpga platform

Marek Vasut marex at denx.de
Mon Dec 18 12:44:11 UTC 2017


On 12/18/2017 01:30 PM, Andrey Zhizhikin wrote:
> Hello Marek,

Hi,

> On Mon, Dec 18, 2017 at 12:39 PM, Marek Vasut <marex at denx.de> wrote:
>> On 12/18/2017 12:10 PM, Andrey Zhizhikin wrote:
>>> Enable CONFIG_CMD_PART item, as default environment requires it
>>> and complains this command in unknown.
>>
>> Fine by me, but what about the other boards, don't they need this as well ?
> 
> I'd say this is applicable to other boards in socfpga family as well.
> The only reason I didn't include them as well into this commit is I
> don't have those boards on hands to perform verification. But I can
> assume since a lot of people uses ENV files to overwrite defaults -
> this should not affect anyone. Please let me know what you think, and
> I can re-submit this patch to include part command in all socfpga
> family configs.

Let's keep it consistent, include all the others. Also make sure to run
make savedefconfig to place that defconfig entry at the right location
if you don't already .

>> btw diffstat is missing and the tags are wrong (should be ARM:
>> socfpga:). I can fix those up, but see my question above...
>>
> 
> Thanks a lot for pointing this out! I quickly checked the log on those
> files, and missed those points out... If you would agree on my
> proposal below, then I get those resolved as well.

Fine.

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list