[U-Boot] [PATCH v2 2/5] board: TI K2G: FC SoC 1GHz and DDR3 1066 MT/s support

[Lokesh Vutla]

On Wednesday 20 December 2017 09:35 PM, Tom Rini wrote:
> On Wed, Dec 20, 2017 at 08:59:37PM +0530, Lokesh Vutla wrote:
>> From: Rex Chang <rchang at ti.com>
>>
>> Added support for K2G EVM with FlipChip SoC of which
>> ARM/DDR3 runs at 1GHz/1066 MT/s. The patch is also
>> backward compatible with old revision EVM and EVM
>> with WireBond SoC. Their ARM/DDR3 run at 600MHz/800 MT/s.
>>
>> The new SoC supports 2 different speeds at 1GHz and 600MHz.
>> Modyfied the CPU Name to show which SoC is used in the EVM.
>> Modified the DDR3 configuration to reflect New SoC supports
>> 2 different CPU and DDR3 speeds, 1GHz/1066MT and 600MHz/800MT.
>>
>> Added new inline function board_it_k2g_g1() for the new FlipChip 1GHz,
>> and set the u-boot env variable board_name accordingly.
>>
>> Modified findfdt script in u-boot environment variable to include new k2g board type.
>>
>> Signed-off-by: Rex Chang <rchang at ti.com>
>> Signed-off-by: Lokesh Vutla <lokeshvutla at ti.com>
> [snip]
>> diff --git a/board/ti/ks2_evm/board_k2g.c b/board/ti/ks2_evm/board_k2g.c
>> index 01328f1955..88df419b10 100644
>> --- a/board/ti/ks2_evm/board_k2g.c
>> +++ b/board/ti/ks2_evm/board_k2g.c
>> @@ -55,7 +55,7 @@ unsigned int get_external_clk(u32 clk)
>>  	return clk_freq;
>>  }
>>  
>> -static int arm_speeds[DEVSPEED_NUMSPDS] = {
>> +int speeds[DEVSPEED_NUMSPDS] = {
> 
> With some quick git grep'ing, this should still be static, yes?  And
> then board/ti/ks2_evm/board_k2e.c should have its existing field marked
> as static too.

For k2g, speeds array is used in arch/arm/mach-keystone/init.c. So
removed static from here. For k2e yes, it should be static. Will send a
separate patch for fixing it.

> 
> [snip]
>> diff --git a/board/ti/ks2_evm/ddr3_k2g.c b/board/ti/ks2_evm/ddr3_k2g.c
>> index 44db335580..923401cfd2 100644
>> --- a/board/ti/ks2_evm/ddr3_k2g.c
>> +++ b/board/ti/ks2_evm/ddr3_k2g.c
> [snip]
>> @@ -53,6 +54,46 @@ struct ddr3_phy_config ddr3phy_800_2g = {
>>  	.pir_v2         = 0x00000F81ul,
>>  };
>>  
>> +struct ddr3_phy_config ddr3phy_1066_2g = {
> 
> And then all of these too should be static?
> 

Right, will post v3 fixing this.

Thanks and regards,
Lokesh