[U-Boot] [PATCH 01/11] cmd: crc32: Disable by default on sunXi

Andre Przywara andre.przywara at arm.com
Thu Dec 21 14:50:29 UTC 2017


Hi,

On 21/12/17 12:40, Maxime Ripard wrote:
> The sunXi arm64 build has overflown, leading to the main U-boot binary
> overwriting the environment when flashing the new image, or even worse,
> overwriting itself when we're calling saveenv.
> 
> Disable this command that is not critical until we can adress the issue
> properly.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> ---
>  cmd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index c0332235261f..7751001819d0 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -397,6 +397,7 @@ menu "Memory commands"
>  config CMD_CRC32
>  	bool "crc32"
>  	select HASH
> +	default n if ARCH_SUNXI

Is that meant to solve issues with 32 bit boards as well? Or shall we
use "ARCH_SUNXI && ARM64" here?

In case including 32-bit is intentional, this is:

for [PATCH 01/11] - [PATCH 04/11]:
Reviewed-by: Andre Przywara <andre.przywara at arm.com>

If no one shoot any of those options down, you might want to squash them
into one patch, since they all go into the same file.
Unless you need to meet some company patch count target before the end
of the year :-D

Cheers,
Andre.

P.S. Shall we mark those patches somehow, so that we can easily revert
them later? Those commands can be useful.

Cheers,
Andre

>  	default y
>  	help
>  	  Compute CRC32.
> 


More information about the U-Boot mailing list