[U-Boot] [PATCH v2 14/18] rockchip: pinctrl: rk322x: Move the iomux definitions into pinctrl-driver

[David.Wu]

Hi Heiko

在 2017/12/26 2:59, Heiko Stuebner 写道:
> Hi David,
> 
> Am Donnerstag, 9. November 2017, 17:24:58 CET schrieb David Wu:
>> diff --git a/arch/arm/mach-rockchip/rk322x-board-spl.c b/arch/arm/mach-rockchip/rk322x-board-spl.c
>> index 35f4f97..f7c6045 100644
>> --- a/arch/arm/mach-rockchip/rk322x-board-spl.c
>> +++ b/arch/arm/mach-rockchip/rk322x-board-spl.c
>> @@ -30,7 +30,25 @@ DECLARE_GLOBAL_DATA_PTR;
>>   
>>   void board_debug_uart_init(void)
>>   {
>> -static struct rk322x_grf * const grf = (void *)GRF_BASE;
>> +       static struct rk322x_grf * const grf = (void *)GRF_BASE;
>> +       enum {
>> +               GPIO1B2_SHIFT           = 4,
>> +               GPIO1B2_MASK            = 3 << GPIO1B2_SHIFT,
>> +               GPIO1B2_UART1_SIN,
>> +               GPIO1B2_UART21_SIN,
>> +
>> +               GPIO1B1_SHIFT           = 2,
>> +               GPIO1B1_MASK            = 3 << GPIO1B1_SHIFT,
>> +               GPIO1B1_UART1_SOUT,
>> +               GPIO1B1_UART21_SOUT,
> 
> You seem to drop the GPIO1B1_GPIO = 0, line, so the enum counting
> wil get jumbled, because GPIO1B1_UART1_SOUT for example will get to
> be 4 instead of the 1 it needs to be.
> 
> This may be true for the other patches for the other socs as well,
> so you may want to double check?
> 

Yes, they are needed to check again.

> 
> Heiko
> 
> 
>