[U-Boot] [u-boot PATCH v2 6/8] ARM: Use Kconfig for board EEPROM's I2C bus and chip address

[Tom Rini]

On Wed, Feb 01, 2017 at 03:05:18PM +0200, Roger Quadros wrote:
> On 01/02/17 14:14, Tom Rini wrote:
> > On Wed, Feb 01, 2017 at 02:01:11PM +0200, Roger Quadros wrote:
> >> On 01/02/17 12:47, Lokesh Vutla wrote:
> >>>
> >>>
> >>> On Wednesday 01 February 2017 03:12 PM, Roger Quadros wrote:
> >>>> On 31/01/17 06:17, Lokesh Vutla wrote:
> >>>>>
> >>>>>
> >>>>> On Monday 30 January 2017 08:45 PM, Roger Quadros wrote:
> >>>>>> In stead of defining the board EEPROM address in the board headers
> >>>>>> let's define them in the board config files and make them
> >>>>>> configurable by Kconfig.
> >>>>>>
> >>>>>> Signed-off-by: Roger Quadros <rogerq at ti.com>
> >>>>>> ---
> >>>>>>  arch/arm/Kconfig                  | 10 ++++++++++
> >>>>>>  configs/am57xx_evm_defconfig      |  2 ++
> >>>>>>  configs/am57xx_evm_nodt_defconfig |  2 ++
> >>>>>>  configs/am57xx_hs_evm_defconfig   |  2 ++
> >>>>>>  configs/dra7xx_evm_defconfig      |  2 ++
> >>>>>>  configs/dra7xx_hs_evm_defconfig   |  2 ++
> >>>>>>  include/configs/am57xx_evm.h      |  4 ----
> >>>>>>  include/configs/dra7xx_evm.h      |  4 ----
> >>>>>>  8 files changed, 20 insertions(+), 8 deletions(-)
> >>>>>>
> >>>>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> >>>>>> index c04adfb..19886ad 100644
> >>>>>> --- a/arch/arm/Kconfig
> >>>>>> +++ b/arch/arm/Kconfig
> >>>>>> @@ -1009,6 +1009,16 @@ config TARGET_THUNDERX_88XX
> >>>>>>  
> >>>>>>  endchoice
> >>>>>>  
> >>>>>> +config EEPROM_BUS_ADDRESS
> >>>>>> +        int "Board EEPROM's I2C bus address"
> >>>>>> +        range 0 8
> >>>>>> +        default 0
> >>>>>> +
> >>>>>> +config EEPROM_CHIP_ADDRESS
> >>>>>> +        hex "Board EEPROM's I2C chip address"
> >>>>>> +        range 0 0xff
> >>>>>> +        default 0x50
> >>>>>> +
> >>>>>
> >>>>> IMO, these should be placed in board/ti/common/Kconfig. Also need not
> >>>>> specify the value explicitly in defconfig if default value is used.
> >>>>
> >>>> "board/ti/common/Kconfig" is not used by keystone
> >>>> Is it OK to source it in board/ti/ks2_evm/Kconfig?
> >>>
> >>> yes. I don't see any problem with that :)
> >>>
> >>
> >> If I do that I get the below error.
> >> I think it is because SPL_NAND is being enabled but not required for K2?
> >> Are all options in ti/common/Kconfig relevant for K2?
> > 
> > The Kconfig file may need some minor tweaks / dependencies added to be
> > used on keystone, and long term we'll be doing all of those "config
> > SPL_FOO\ndefault y" entries another way.  The NAND entry could be
> > changed (but you'll need to test, and shoving a test branch at travis-ci
> > is an easy way to test) to be instead of 'default y' be 'default
> > CMD_NAND' I think.
> 
> It starts to look ugly if I add conditions in the Kconfig file.
> Why are we setting default y to various SPL_* options in this file?
> Shouldn't the board config file explicitly set the values?
> e.g. some TI board might not need SPL_I2C and other might need it.

Until the 'imply' keyword comes in to Kconfig we're left with a few
different ugly options in order to avoid having to make the defconfig
files themselves unwieldy.  A 'default y' does not make it impossible to
disable the feature, but changing the default here potentially easier
than setting it to N in the various k2 defconfig files, for example.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170201/fc44d251/attachment.sig>