[U-Boot] [PATCH] serial: 16550: properly initialize fcr field of ns16550_platdata

[Heiko Schocher]

Hello Oleksandr,

Am 01.02.2017 um 19:52 schrieb Oleksandr Tymoshenko:
> Tom Rini (trini at konsulko.com) wrote:
>> On Tue, Jan 31, 2017 at 05:15:20PM -0800, Oleksandr Tymoshenko wrote:
>>
>>> Default fcr value is initialized in ns16550_serial_ofdata_to_platdata
>>> but this function is only called if OF_CONTROL option is enabled while
>>> the field is used whenever DM_SERIAL is set. So for configs that
>>> do not have OF_CONTROL default fcr value is set to zero which leads
>>> to loosing characters when serial port input is faster than reading
>>> routine i.e. when copy-pasting long line to U-Boot prompt.
>>>
>>> As a fix initialize fcr field in probe method
>>>
>>> Signed-off-by: Oleksandr Tymoshenko <gonzo at bluezbox.com>
>>> Cc: Marek Vasut <marex at denx.de>
>>> Cc: Tom Rini <trini at konsulko.com>
>>> Cc: Simon Glass <sjg at chromium.org>
>>
>> Are you still seeing this with v2017.03-rc1?  Thanks!
>
> No, this bug is not reproducible on v2017.03-rc1, I believe 17fa032671
> fixed it. Not sure how I missed that patch I am pretty sure I tested my
> BBB with master branch.

Yes commit 17fa032671 fixed this issue. How do you test? You must
type very fast, or copy&paste a long command ...

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany