[U-Boot] [PATCH] net: phy: vitesse: Fix cis8204 RGMII_ID code

Joe Hershberger joe.hershberger at gmail.com
Thu Feb 2 17:46:07 UTC 2017


On Mon, Dec 12, 2016 at 9:27 AM, Phil Edworthy
<phil.edworthy at renesas.com> wrote:
> Commit 79e86ccb3786c8b20004db3fa10a70049456f580 "vitesse: remove duplicated
> argument to ||" correctly removed a redundant check.
>
> However, I believe that the original code was simply wrong, and should have
> been checking against RGMII_ID.
>
> To fix this and avoid similar problems in the future, use the
> phy_interface_is_rgmii helper function.
>
> Signed-off-by: Phil Edworthy <phil.edworthy at renesas.com>
> ---
> This has _not_ been tested in any way, shape or form! It was picked
> up when converting PHY code to use the phy_interface_is_rgmii helper
> function.

Seems reasonable.

Acked-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list