[U-Boot] [PATCH v4 2/2] SPL: Move SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION to Kconfig
Dalon Westergreen
dwesterg at gmail.com
Fri Feb 3 19:15:21 UTC 2017
On Fri, 2017-02-03 at 12:17 -0500, Tom Rini wrote:
> On Fri, Feb 03, 2017 at 09:13:43AM -0800, Dalon Westergreen wrote:
> >
> > On Fri, 2017-02-03 at 11:05 -0600, Dinh Nguyen wrote:
> > >
> > > Hi Dalon,
> > >
> > > On 02/01/2017 10:45 AM, Dalon Westergreen wrote:
> > > >
> > > >
> > > > From: Dalon Westergreen <dalon.westergreen at intel.com>
> > > >
> > > > Added SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION and
> > > > SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION to Kconfig.
> > > >
> > > > set to default y for socfpga platforms, and add appropriate
> > > > configurations for kc1, snipper, and db-88f6820-gp boards.
> > > >
> > > > Signed-off-by: Dalon Westergreen <dwesterg at gmail.com>
> > > > ---
> > > > common/spl/Kconfig | 18 +++++++++++++++++-
> > > > common/spl/spl_mmc.c | 12 +++---------
> > > > configs/db-88f6820-gp_defconfig | 1 +
> > > > configs/kc1_defconfig | 2 ++
> > > > configs/sniper_defconfig | 2 ++
> > > > include/configs/db-88f6820-gp.h | 1 -
> > > > include/configs/kc1.h | 2 --
> > > > include/configs/sniper.h | 2 --
> > > > 8 files changed, 25 insertions(+), 15 deletions(-)
> > > >
> > >
> > > I'm get this warning:
> > >
> > > include/configs/socfpga_common.h:316:0: warning:
> > > "CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION" redefined
> > > #define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION 1
> > >
> > > Need to remove the CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION from
> > > socfpga_common.h as well.
> > Yes, i am aware, but have a separate patch set already for the socfpga
> > headers. i think it may be best just to redo those after this is
> > merged. i will add the modifications to the socfpga headers.
>
> The series needs to be complete and not add warnings. Ideally we won't
> add warnings in one patch and fix them in a later patch.
>
okay. this is fixed in the v5 patches i just sent.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
More information about the U-Boot
mailing list