[U-Boot] [PATCH v3 04/13] sunxi: simplify ACTLR.SMP bit set #ifdef

Andre Przywara andre.przywara at arm.com
Mon Feb 6 12:29:26 CET 2017


Hi,

On 03/02/17 10:52, Jagan Teki wrote:
> On Wed, Feb 1, 2017 at 2:36 AM, Andre Przywara <andre.przywara at arm.com> wrote:
>> Instead of enumerating all SoC families that need that bit set, let's
>> just express this more clearly: The SMP bits needs to be set on
>> SMP capable ARMv7 CPUs. It's much easier in Kconfig to express it the
>> other way round, so we use ! CPU_IS_UP and ! ARM64.
>>
>> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
>> Acked-by: Maxime Ripard <maxime.ripard at free-electrons.com>
>> ---
>>  arch/arm/Kconfig            | 4 ++++
>>  arch/arm/mach-sunxi/board.c | 5 +----
>>  board/sunxi/Kconfig         | 2 ++
>>  3 files changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index fc36723..98791c0 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -126,6 +126,10 @@ config ENABLE_ARM_SOC_BOOT0_HOOK
>>           ARM_SOC_BOOT0_HOOK which contains the required assembler
>>           preprocessor code.
>>
>> +config ARM_CORTEX_CPU_IS_UP
>> +       bool
>> +       default n
> 
> Better to place this in sunxi, since no other code using this expect
> sunxi and the name CORTEX may also refer arm64 use something 32
> related.

Sigh, can you please check back with Maxime on what's the right thing here?
http://lists.denx.de/pipermail/u-boot/2017-January/279417.html

If it's about the name, shall we use ARM_CORTEX_V7_CPU_IS_UP?

I was briefly tempted to unify all ACTLR.SMP bit sets from all over the
ARM code, but this looks like a can of worms to me, so I'd rather keep
this one closed.

Cheers,
Andre.


More information about the U-Boot mailing list