[U-Boot] [PATCH] arm: dts: dra7: add qspi register map for control module
Tom Rini
trini at konsulko.com
Mon Feb 6 14:37:13 CET 2017
On Mon, Feb 06, 2017 at 02:27:42PM +0100, Jean-Jacques Hiblot wrote:
>
>
> On 06/02/2017 13:47, Tom Rini wrote:
> >On Mon, Feb 06, 2017 at 12:09:12PM +0100, Jean-Jacques Hiblot wrote:
> >>
> >>On 03/02/2017 17:52, Tom Rini wrote:
> >>>On Wed, Feb 01, 2017 at 11:53:42AM +0100, Jean-Jacques Hiblot wrote:
> >>>
> >>>>Add qspi control module register maps to device tree. This register map had
> >>>>been removed by error when syncing the DTS with the latest linux at the
> >>>>time (commit 7aa1a4087 "ARM: dts: dra7xx: sync DT with latest Linux").
> >>>>Without this entry the driver do not support memory-mapped access and the
> >>>>data read from the SF is invalid.
> >>>>
> >>>>Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
> >>>Why is this not in the upstream DTS file?
> >>In Linux, a syscon/regmap is used to map this register while the
> >>QSPI driver in u-boot uses a direct memory access.
> >OK, but it's a valid part of the upstream kernel binding, yes?
> syscon-chipselects is part of the mainlined binding. Using a 3rd
> memory range used to be the way to do it, but it is not supported
> anymore (I think it has been removed removed in 4.6).
> Using a third memory range has been supported in u-boot for some time now.
> So you think we should move to using the syscon ?
Based on what I see in v4.10-rc7, yes, we should adapt the driver to
know about the new property and things are working as expected wrt DT
compatibility.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170206/52230607/attachment.sig>
More information about the U-Boot
mailing list