[U-Boot] [RFC PATCH v3 07/11] net: Add ping6 command and implementation

[Simon Glass]

Hi Chris,

On 25 January 2017 at 01:56, Chris Packham <judge.packham at gmail.com> wrote:
> Signed-off-by: Chris Packham <judge.packham at gmail.com>
>
> ---
>
> Changes in v3: None
> Changes in v2:
> - split ping6 support into it's own patch
>
>  cmd/Kconfig   |   6 ++++
>  cmd/net.c     |  28 +++++++++++++++
>  include/net.h |   4 +--
>  net/net6.c    |   7 ++++
>  net/ping6.c   | 111 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 154 insertions(+), 2 deletions(-)
>  create mode 100644 net/ping6.c
>

Reviewed-by: Simon Glass <sjg at chromium.org>

I'm not keen on the global variables (e.g. seq_no). Can they go in a
struct and be stored in the uclass private data for the Ethernet?

- Simon