[U-Boot] [PATCH 4/5] configs: am335x: Enable PHY_VITESSE

Andrew F. Davis afd at ti.com
Mon Feb 6 19:47:09 UTC 2017


On 02/06/2017 01:02 PM, Alex G. wrote:
> On 02/06/2017 07:56 AM, Andrew F. Davis wrote:
>> On 02/03/2017 05:42 PM, Alexandru Gagniuc wrote:
>>> The Adaptrum ACRS2 mainboard uses a Vitesse VSC8601 PHY.
>>>
>>> Signed-off-by: Alexandru Gagniuc <alex.g at adaptrum.com>
>>> ---
>>>  include/configs/am335x_evm.h | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
>>> index cd42601..b0014cf 100644
>>> --- a/include/configs/am335x_evm.h
>>> +++ b/include/configs/am335x_evm.h
>>> @@ -366,6 +366,7 @@
>>>  #define CONFIG_PHY_SMSC
>>>  /* Enable Atheros phy driver */
>>>  #define CONFIG_PHY_ATHEROS
>>> +#define CONFIG_PHY_VITESSE
>>>
>>
>> These PHY symbols should instead be moved to Kconfig, lets try not to
>> add anything new to the config headers :)
> 
> The whole PHY_ seclection does seem like it could use a major rework. I
> was hoping to not have to touch Kconfig in this series, but if that is
> the will, I shall yield.
> 

It's really not so bad, have you ever used tools/moveconfig.py? Just
define the symbol in kconfig and it will do all the work for you. The
more people forced to at least try it out the quicker we can finish with
this the conversion.

Andrew

> Alex
> 
>>
>> Andrew
>>
>>>  /*
>>>   * NOR Size = 16 MiB
>>>


More information about the U-Boot mailing list