[U-Boot] [PATCH v2 02/15] cmd: nand: abstract global variable usage for dm conversion

[Tom Rini]

On Thu, Feb 09, 2017 at 11:51:38AM -0600, Grygorii Strashko wrote:
> Hi Tom,
> 
> On 02/05/2017 07:57 PM, Tom Rini wrote:
> > On Tue, Jan 31, 2017 at 03:37:04PM -0600, Grygorii Strashko wrote:
> > 
> >> From: Mugunthan V N <mugunthanvnm at ti.com>
> >>
> >> nand_info is used all over the file so abstract it with
> >> get_nand_dev_by_index() which will help for DM conversion.
> >>
> >> Signed-off-by: Mugunthan V N <mugunthanvnm at ti.com>
> >> Signed-off-by: Grygorii Strashko <grygorii.strashko at ti.com>
> > 
> > Reviewed-by: Tom Rini <trini at konsulko.com>
> > 
> 
> Sry, I've not received your last comment:
> "So this is incomplete and breaks omap3_beagle booting for example, we
> hang during bootup."
> 
> I have one question - was boot tested only with this patch or with whole series?

I tested with up until the TI driver was converted itself.  So... if
this series requires all drivers to have been converted in order to not
hang, then you need to convert all of the drivers to use the helper to
not break bisectability.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170209/e75a958c/attachment.sig>