[U-Boot] [PATCH v2 11/15] drivers: nand: omap_gpmc: convert driver to adopt driver model
Simon Glass
sjg at chromium.org
Fri Feb 10 16:22:33 UTC 2017
Hi,
On 31 January 2017 at 14:37, Grygorii Strashko <grygorii.strashko at ti.com> wrote:
> From: Mugunthan V N <mugunthanvnm at ti.com>
>
> adopt omap_gpmc driver to driver model.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm at ti.com>
> Signed-off-by: Grygorii Strashko <grygorii.strashko at ti.com>
> ---
> drivers/mtd/nand/omap_gpmc.c | 205 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 205 insertions(+)
>
My only comment here is that it looks like read_buf and the like
should be operations implemented by the NAND uclass. See struct
dm_mmc_ops for how it works for mmc.
Regards,
Simon
More information about the U-Boot
mailing list