[U-Boot] [PATCH v3 6/9] STiH410: Add STi SDHCI driver

Jaehoon Chung jh80.chung at samsung.com
Mon Feb 13 00:29:36 UTC 2017


Hi,

On 02/11/2017 12:04 AM, patrice.chotard at st.com wrote:
> From: Patrice Chotard <patrice.chotard at st.com>
> 
> Add SDHCI host controller found on STMicroelectronics SoCs
> 
> On some ST SoCs, i.e. STiH407/STiH410, the MMC devices can live
> inside a dedicated flashSS sub-system that provides an extend subset
> of registers that can be used to configure the Arasan MMC/SD Host
> Controller.
> 
> This means, that the SDHCI Arasan Controller can be configured to be
> eMMC4.5 or 4.3 spec compliant.
> 
> W/o these settings the SDHCI will configure and use the MMC/SD
> controller with limited features e.g. PIO mode, no DMA, no HS etc.
> 
> Signed-off-by: Patrice Chotard <patrice.chotard at st.com>

Looks good to me, except Simon's comments.
You can fix the Simon's comments.
If you can add the Changelog about each versions, it might be more better. :)

Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>

Best Regards,
Jaehoon Chung

> ---



More information about the U-Boot mailing list