[U-Boot] [PATCH 04/10] arm64: a37xx: Handle pin controls in early board init

[Konstantin Porotchkin]

On 02/14/2017 02:25 PM, Konstantin Porotchkin wrote:
>
>
> On 2/14/2017 14:21, Stefan Roese wrote:
>> On 14.02.2017 13:07, Konstantin Porotchkin wrote:
>>> Hi, Stefan,
>>>
>>> On 2/14/2017 13:43, Stefan Roese wrote:
>>>> Hi Kosta,
>>>>
>>>> On 13.02.2017 14:38, kostap at marvell.com wrote:
>>>>> From: Konstantin Porotchkin <kostap at marvell.com>
>>>>>
>>>>> Fix the default pin control values in a board-specific
>>>>> function on early board init stage.
>>>>> This fix allows the NETA driver to work in RGMII
>>>>> mode until the full-featured pin control driver gets
>>>>> introduced.
>>>>>
>>>>> Signed-off-by: Konstantin Porotchkin <kostap at marvell.com>
>>>>> Cc: Stefan Roese <sr at denx.de>
>>>>> Cc: Igal Liberman <igall at marvell.com>
>>>>> ---
>>>>>  board/Marvell/mvebu_db-88f3720/board.c | 26
>>>>> +++++++++++++++++++++++++-
>>>>>  1 file changed, 25 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/board/Marvell/mvebu_db-88f3720/board.c
>>>>> b/board/Marvell/mvebu_db-88f3720/board.c
>>>>> index edf88c7..3337f3f 100644
>>>>> --- a/board/Marvell/mvebu_db-88f3720/board.c
>>>>> +++ b/board/Marvell/mvebu_db-88f3720/board.c
>>>>> @@ -19,9 +19,33 @@ DECLARE_GLOBAL_DATA_PTR;
>>>>>  #define I2C_IO_REG_0_SATA_OFF    2
>>>>>  #define I2C_IO_REG_0_USB_H_OFF    1
>>>>>
>>>>> +#define PINCTRL_NB_REG_VALUE    0x000173fa
>>>>> +#define PINCTRL_SB_REG_VALUE    0x00007a23
>>>>> +
>>>>
>>>> I am aware that this is a temporary solution, but are these values
>>>> correct for the A3720-DB or only the ESPRESSBin board?
>>> They are good for the DB board as well. Actually without this change the
>>> NETA driver will crash if we try to ping the server.
>>
>> Okay. And do you have any ideas on when this pinctrl driver might be
>> available?
> I will query our team that is responsible for A37xx features. I think
> they are currently working on SATA/SCSI issues discovered when moved to
> the new code base. Hope the pin control will be the next task, but I
> have to ensure it.

Just got an update - the pin control driver task is scheduled to March.
>
>>
>>>>
>>>> BTW: You are now using the "Marvell/mvebu_db-88f3720" board directory
>>>> for multiple board and not only the A3720-DB. I would prefer to see
>>>> a rename of the board directory before this, like we've done to the
>>>> A7k/8k directory. What do you think?
>>> Agree, I can do it. Should we change it in this patch series or
>>> introduce an additional patch later?
>>
>> We have no chance to get this patchset into this release, so we have
>> a bit of time for the next one. I would prefer a clean switch and
>> add this rename as one of the first patches in the next version of
>> this patchset.
> Ok, got you, I will work on this change.
>
>>
>> Thanks,
>> Stefan