[U-Boot] [PATCH v5 0/6] Allow disabling non-FIT image loading from SPL

[Tom Rini]

On Thu, Feb 16, 2017 at 08:40:37AM -0600, Andrew F. Davis wrote:
> On 02/15/2017 05:59 PM, Tom Rini wrote:
> > On Wed, Feb 15, 2017 at 01:45:45PM -0600, Andrew F. Davis wrote:
> > 
> >> Hello all,
> >>
> >> To address a needed feature brought up by Andreas[0], we need a way to
> >> disable SPL from loading non-FIT images.
> >>
> >> The function spl_parse_image_header is common to all SPL loading paths
> >> (common/spl/spl_(nand|net|nor|etc..)) so we add the check here.
> >>
> >> This version of the series is a bit different than the last 2 due
> >> to suggestions by Simon, instead of a negative option disabling
> >> non-FIT images, we allow the other image format's support to be
> >> toggled off, and do that on HS boards.
> > 
> > I think this would be cleaner if we introduce the symbols to be default
> > n if TI_SECURE_DEVICE and then we don't have to modify the defconfig
> > files.  That said, we should probably do that as a new patch #3 so it's
> > clear in the commit history when we default it off.  Thanks!
> 
> Hmmm, I'm really not a fan of this, disabling these options is only
> needed on a couple boards and so should go in their defconfig, adding
> the per-board exceptions to the symbol definition itself will start to
> cause massive kconfig bloat.
> 
> If you strongly disagree, below is a patch #3, if you take this you can
> drop the defconfig patches from this series.

One thing that I feel is different in U-Boot from the Linux kernel is
that I'm OK with putting more logic into the Kconfig files so that we
get reasonable default output, even if it's only a "handful" of boards.
I imagine that a follow up patch would change the logic to "default y if
!TI_SECURE_DEVICES && !FSL_SIMILAR_SYMBOL"  Or perhaps even doing
another line of "default n if TI_SECURE_DEVICES || FSL_... || ..."

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170216/0a53dfe3/attachment.sig>