[U-Boot] [PATCH 1/8] arm: socfpga: Add distro boot to socfpga common header
Dalon Westergreen
dwesterg at gmail.com
Sun Feb 19 19:59:51 UTC 2017
On Sun, 2017-02-19 at 20:45 +0100, Pavel Machek wrote:
> Hi!
>
> >
> > >
> > > >
> > > > >
> > > > > >
> > > > > > /* Environment for SDMMC boot */
> > > > > > #if defined(CONFIG_ENV_IS_IN_MMC) && !defined(CONFIG_ENV_OFFSET)
> > > > > > -#define CONFIG_SYS_MMC_ENV_DEV 0 /* device 0
> > > > > > */
> > > > > > -#define CONFIG_ENV_OFFSET 512 /* just after
> > > > > > the
> > > > > > MBR
> > > > > > */
> > > > > > +#define CONFIG_SYS_MMC_ENV_DEV 0 /*
> > > > > > device 0
> > > > > > */
> > > > > > +#define CONFIG_ENV_OFFSET (34*512)/* just after the
> > > > > > GPT
> > > > > > */
> ...
> >
> > I actually dont believe this will cause much of an issue. the env is placed
> > immediately after the partition table. I know this size fits between the
> > table and the typical location of the first partition without issue.
>
> Hmm. It is not immediately after partition table (==MBR), it is at
> sector 34. Now, by changing size you already break the setups, so
> moving it back to sector 1 does not help much, but can you explain?
Sorry, you are right. Frank had moved it after the GPT in his patchset and i
had just copied that. i will update this to be immediately after the mbr as
it was before.
--dalon
>
> Pavel
More information about the U-Boot
mailing list