[U-Boot] [PATCH v4 1/8] arm: socfpga: Add distro boot to socfpga common header

[Marek Vasut]

On 02/19/2017 09:44 PM, Dalon Westergreen wrote:
> On Sun, 2017-02-19 at 21:35 +0100, Marek Vasut wrote:
>> On 02/19/2017 09:20 PM, Dalon Westergreen wrote:
>>>
>>> This adds a common environment and support for distro boot
>>> in the common socfpga header.
>>>
>>> Signed-off-by: Dalon Westergreen <dwesterg at gmail.com>
>>> Acked-by: Marek Vasut <marex at denx.de>
>>>
>>> --
>>> Changes in v4:
>>>  - Move env back to being right after the MBR
>>> Changes in v3:
>>>  - fix spacing between asterix
>>>  - remove verify=n as a default setting
>>>
>>> Changes in v2:
>>>  - Remove unneeded CONFIG_BOOTFILE and fdt_addr
>>>  - cleanup spacing in MMC env size
>>> ---
>>>  include/configs/socfpga_common.h | 52 ++++++++++++++++++++++++++++++++++++-
>>> ---
>>>  1 file changed, 48 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/include/configs/socfpga_common.h
>>> b/include/configs/socfpga_common.h
>>> index 582b04a..55e0bf9 100644
>>> --- a/include/configs/socfpga_common.h
>>> +++ b/include/configs/socfpga_common.h
>>> @@ -67,6 +67,9 @@
>>>  #define CONFIG_SYS_HOSTNAME	CONFIG_SYS_BOARD
>>>  #endif
>>>  
>>> +#define CONFIG_CMD_PXE
>>> +#define CONFIG_MENU
>>> +
>>>  /*
>>>   * Cache
>>>   */
>>> @@ -245,13 +248,13 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
>>>   * U-Boot environment
>>>   */
>>>  #if !defined(CONFIG_ENV_SIZE)
>>> -#define CONFIG_ENV_SIZE			4096
>>> +#define CONFIG_ENV_SIZE			(8 * 1024)
>>>  #endif
>>>  
>>>  /* Environment for SDMMC boot */
>>>  #if defined(CONFIG_ENV_IS_IN_MMC) && !defined(CONFIG_ENV_OFFSET)
>>> -#define CONFIG_SYS_MMC_ENV_DEV		0	/* device 0 */
>>> -#define CONFIG_ENV_OFFSET		512	/* just after the MBR
>>> */
>>> +#define CONFIG_SYS_MMC_ENV_DEV		0 /* device 0 */
>>> +#define CONFIG_ENV_OFFSET		512 /* just after the MBR */
>>>  #endif
>>
>> You could've just dropped this part then ;-)
>>
>> IMO the series is fine, let's see what others have to say ...
>>
> im still a bit of a git novice... :)
> 

I use git send-email --annotate to inspect my patches before submission.

-- 
Best regards,
Marek Vasut