[U-Boot] [PATCH 7/7] ti: wdt: Enable OMAP watchdog in u-boot's board_f.c

Lukasz Majewski lukma at denx.de
Mon Feb 20 07:35:05 UTC 2017


Hi Tom,

> On Sun, Feb 19, 2017 at 11:24:42PM +0100, Lukasz Majewski wrote:
> > The init_func_watchdog_init called in u-boot's board_f.c's
> > init_sequence is responsible for enabling WDT in u-boot and notify
> > user about it.
> > 
> > Several other architectures have adopted it for this purpose.
> > This code does the same with OMAP watchdog.
> > 
> > Signed-off-by: Lukasz Majewski <lukma at denx.de>
> > ---
> >  common/board_f.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/common/board_f.c b/common/board_f.c
> > index ae6cd85..5dd56a4 100644
> > --- a/common/board_f.c
> > +++ b/common/board_f.c
> > @@ -120,7 +120,7 @@ static int init_func_watchdog_init(void)
> >  	defined(CONFIG_M68K) || defined(CONFIG_MICROBLAZE) || \
> >  	defined(CONFIG_SH) || defined(CONFIG_AT91SAM9_WATCHDOG) ||
> > \ defined(CONFIG_DESIGNWARE_WATCHDOG) || \
> > -	defined(CONFIG_IMX_WATCHDOG))
> > +	defined(CONFIG_IMX_WATCHDOG) ||
> > defined(CONFIG_OMAP_WATCHDOG))
> 
> Please introduce a new symbol here with a reasonable name and select
> it on the various platforms, then make OMAP also select it.  Thanks!

Something similar to CONFIG_SPL_HW_WATCHDOG bu for u-boot?

That would be something like CONFIG_HW_WATCHDOG_INIT ...

> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170220/223e3747/attachment.sig>


More information about the U-Boot mailing list