[U-Boot] [PATCH v2 1/2] common: image: update boot_get_fpga to support arbitrary fpga image

[Marek Vasut]

On 02/20/2017 03:42 PM, Dalon Westergreen wrote:
> On Mon, 2017-02-20 at 09:14 +0100, Marek Vasut wrote:
>> On 02/20/2017 04:35 AM, Dalon Westergreen wrote:
>>>
>>> The implementation of boot_get_fpga only supported one fpga family.
>>> This modification allows for any of the fpga devices supported by
>>> fpga_load to be used.
>>>
>>> Signed-off-by: Dalon Westergreen <dwesterg at gmail.com>
>>
>> IMO looks OK, minor nits below
>>
>>>
>>> --
>>> Changes in v2:
>>>  - Add fitimage support for fpga-devnum and fpga-partial-image
>>>  - Use above in boot_get_fpga
>>>  - for xilinx fpgas double check using image size to determine
>>>    if image is a partial image
>>> ---
>>>  common/image-fit.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  common/image.c     | 51 ++++++++++++++++++++++++++++++++-------------------
>>>  include/image.h    |  5 +++++
>>>  3 files changed, 88 insertions(+), 19 deletions(-)
>>>
>>> diff --git a/common/image-fit.c b/common/image-fit.c
>>> index 109ecfa..eb0c633 100644
>>> --- a/common/image-fit.c
>>> +++ b/common/image-fit.c
>>> @@ -916,6 +916,57 @@ ulong fit_get_end(const void *fit)
>>>  }
>>>  
>>>  
> [...]
>>>
>>> +		fit_image_fpga_get_devnum(buf, conf_noffset, &devnum);
>>> +
>>> +		/* check bitstream type */
>>
>> At least start the sentence with capital letter please.
>>
>>>
>>> +		if (fit_image_fpga_is_partial(buf, conf_noffset))
>>> +			bstype = BIT_PARTIAL;
>>
>> Are there any chances there will be something else besides full and
>> partial in the future ?
> 
> It's plausible but i think not a likely use case here. In Arria10 there is the
> periphery/core image that configures just the io or fpga core.  I believe,
> though, that this is just a special case of a partial image and is treated the
> same.

IOCSR ? Hmmm, it'd be great if we could get a real pinmux driver for
socfpga ;-) But that's totally out of context of this discussion ...

-- 
Best regards,
Marek Vasut