[U-Boot] [PATCH v1] sun8i_emac: configure PHY reset GPIO via DM

Dr. Philipp Tomsich philipp.tomsich at theobroma-systems.com
Tue Feb 21 18:17:37 UTC 2017


> On 21 Feb 2017, at 18:57, Maxime Ripard <maxime.ripard at free-electrons.com> wrote:
> 
> On Fri, Feb 17, 2017 at 06:42:42PM +0100, Philipp Tomsich wrote:
>> This ports the support for configuring a GPIO for resetting the
>> Ethernet PHY (incl. such details as the reset polarity and
>> pulse-length) from the Designware driver.
> 
> Isn't that a property of the PHY itself, and not the MAC ?

It’s the MAC trying to signal “power-up the PHY”.
So we modelled it like a “wake-up output” from the MAC...

>> For easier migration for the Designware driver, the prefix of DTB
>> entries has simply been changed from 'snps,' to 'allwinner,':
>> i.e. 'snps,reset-gpio' became 'allwinner,reset-gpio'.
> 
> The upstrmea driver will use the snps prefix.

In fact I have a patch floating around here, which merges the sun8i_emac
back into designware.c (there really isn’t any difference) and then uses the
snps,reset-gpio.

Given that I found it a bit less appropriate to have that patch out first, this
is the consensus change to fall back onto in case the bigger change gets
shot down.

Cheers,
Philipp.



More information about the U-Boot mailing list