[U-Boot] [PATCH] Revert "imx: mx7: implement reset_misc"

[Stefano Babic]

On 22/02/2017 10:33, Fabio Estevam wrote:
> Hi Stefano and Peng,
> 
> On Tue, Feb 21, 2017 at 11:21 PM, Fabio Estevam <festevam at gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam at nxp.com>
>>
>> Commit 9f8fa184fc1ac ("imx: mx7: implement reset_misc") says it needs to
>> to power down lcdif to make 'reset' can pass stress test.
>>
>> However I see 100% of reset failures with this commit applied, so better
>> revert it for now.
>>
>> This reverts commit 9f8fa184fc1acb6fe8e15e3bbbfcb916e6bc4cc1.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
> 
> I realized that the reset failure always happen only when 'videomode'
> variable is not present:
> 

Ouch ! Wrong access ?

> => setenv videomode
> => saveenv
> => reset
> 
> Then reset hangs.
> 
> If I do the check like this, then it does not hang:
> 
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -135,6 +135,11 @@ void lcdif_power_down(void)
>  {
>         struct mxs_lcdif_regs *regs = (struct mxs_lcdif_regs *)MXS_LCDIF_BASE;
>         int timeout = 1000000;
> +       char *penv;
> +
> +       penv = getenv("videomode");
> +       if (!penv)
> +               return;
> 
>         writel(panel.frameAdrs, &regs->hw_lcdif_cur_buf_reg);
>         writel(panel.frameAdrs, &regs->hw_lcdif_next_buf_reg);
> 
> What do you think of such proposal instead of doing the revert?
> 

Fully agree !

Best regards,
Stefano


-- 
Meet DENX at the Embedded World Trade Show
14 Mar - 16 Mar 2017, Nuremberg Trade Fair Centre, Hall 4, Booth 581
--
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================