[U-Boot] [PATCH v1 1/2] sun8i: define CONFIG_PHY_GIGE for EMAC

Maxime Ripard maxime.ripard at free-electrons.com
Wed Feb 22 17:18:41 UTC 2017


On Tue, Feb 21, 2017 at 09:37:14PM +0100, Dr. Philipp Tomsich wrote:
> On 21 Feb 2017, at 20:55, Maxime Ripard <maxime.ripard at free-electrons.com> wrote:
> > 
> > On Fri, Feb 17, 2017 at 06:47:54PM +0100, Philipp Tomsich wrote:
> >> +#ifdef CONFIG_SUN8I_EMAC
> >> +#define CONFIG_PHY_GIGE			/* GMAC can use gigabit PHY	*/
> >> +#endif
> > 
> > It would make more sense to move that option to Kconfig, and selecting
> > it from SUN8I_EMAC.
> 
> CONFIG_PHY_GIGE is not a Kconfig option yet and only enabled via
> board-specific config files.

Which is exactly what I was suggesting to do, sorry if it wasn't clear
:)

We're still in the phase of getting options moved to kconfig, so this
seems like the perfect occasion to do so.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170222/c3d22a9d/attachment.sig>


More information about the U-Boot mailing list