[U-Boot] [PATCH v1 2/2] sun8i: enable support for the Micrel KSZ9031 with SUN8I_EMAC

[Maxime Ripard]

On Wed, Feb 22, 2017 at 03:45:41PM +0100, Dr. Philipp Tomsich wrote:
> Maxime,
> 
> > On 21 Feb 2017, at 21:35, Dr. Philipp Tomsich <philipp.tomsich at theobroma-systems.com> wrote:
> > 
> > Maxime,
> > 
> >> On 21 Feb 2017, at 20:56, Maxime Ripard <maxime.ripard at free-electrons.com> wrote:
> >> 
> >> On Fri, Feb 17, 2017 at 06:47:55PM +0100, Philipp Tomsich wrote:
> >>> #ifdef CONFIG_SUN8I_EMAC
> >>> #define CONFIG_PHY_GIGE			/* GMAC can use gigabit PHY	*/
> >>> +#define CONFIG_PHY_MICREL
> >>> +#define CONFIG_PHY_MICREL_KSZ9031       /* used on A64-uQ7              */
> >>> #endif
> >> 
> >> Same thing here, and that way you could enable it only on the board
> >> defconfig.
> 
> I’d really like to keep this for all SUN8I_EMAC configurations, as we
> need the PHY support to initialise the pad timing parameters from the
> DTS. If these are not initialised, then RGMII (i.e. Gigabit) will not work.

I'm not really discussing whether it is needed or not.

> As we are moving towards a ‘universal’ U-Boot binary for sun50i and
> try to put all board specific info into the DTS, I’d like to keep this in
> sunxi-common.h to ensure that nobody rebuild without it and then
> has issues on our boards.

I'm not buying the whole universal U-Boot binary thing, but that's
really not related to the discussion. sunxi-common.h should be
reduced, not expanded to cover new stuff, in favor of Kconfig.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170222/781e9afc/attachment.sig>