[U-Boot] [Patch v6 8/9] armv8: ls1046ardb: Add LS1046ARDB board support

[chris warth]

I don't know the protocol for revisiting broken patches that have
already been integrated, but the patched offered by NXP for their
ls1046a RDB is wrong.

original patch:
http://lists.denx.de/pipermail/u-boot/2016-September/265974.html

The main error is this patch defines CONFIG_SPI_FLASH_BAR which
enables use of a bank address register to access flash addresses
beyond 16M.

+/* QSPI device */
+#ifdef CONFIG_FSL_QSPI
+#define CONFIG_SPI_FLASH_SPANSION
+#define FSL_QSPI_FLASH_SIZE (1 << 26)
+#define FSL_QSPI_FLASH_NUM 2
+#define CONFIG_SPI_FLASH_BAR
+#endif

However the Cypress S25FS512S part used on the LS1046A RDB does not
implement any bank address related commands.
See section 1.2.2.9 of http://www.cypress.com/file/216376/download

This configuration error means that any attempt to access beyond the
first 16MB of flash will silently wrap around to the beginning of the
flash.
This is in addition to the bugs in flash erase on this platform
previously noted -
http://lists.denx.de/pipermail/u-boot/2016-December/276032.html