[U-Boot] [PATCH 00/12] arm: aspeed: Basic support for Aspeed AST2500 part and eval board

[Maxim Sloyko]

On Wed, Jan 4, 2017 at 12:26 PM, Tom Rini <trini at konsulko.com> wrote:
> On Wed, Jan 04, 2017 at 11:46:44AM -0800, Maxim Sloyko wrote:
>
>> This series adds minimal support for AST2500 part and eval board,
>> enough to boot EVB into prompt. It contains WDT, Timer, Sysreset,
>> Clock (very basic) and SDRAM MC drivers, all written from scratch,
>> using AST2500 datasheet. Aspeed's SDK was used only for reference.
>> Given very limited documentation provided by Aspeed, some parts of SDRAM
>> init sequence were basically rewritten to do the same thing that is done
>> in Aspeed SDK, without real understanding of what is going on.
>>
>> The file layout closely follows the example of rk3288 chip and firefly-rk3288
>> board.
>>
>> For the first round of reviews I'm mostly looking for a nod to add
>> mach-aspeed and arch-aspeed directories, as well as for feedback
>> on naming, file locations and overall approach.
>
> Thanks for doing this.  I'll review the individual patches for other
> changes but in general:
>
>> Maxim Sloyko (12):
>>   aspeed: Add mach-aspeed directory and basic Kconfig
>>   aspeed: Add support for Watchdot Timer
>>   aspeed: Add Timer Support
>>   aspeed: Add sysreset driver
>>   aspeed/ast2500: Device Tree and bindings for some of the clocks
>>   aspeed/ast2500: Add Clock Driver
>>   aspeed/ast2500: Helper function to get access to SCU
>>   aspeed/ast2500: Add SDRAM MC driver
>>   aspeed/ast2500: Common board init functions for ast2500 based boards
>
> This can really be one patch.  Or maybe 2-3 (wdt, timer, sysreset,
> everything else).  The stuff that one could lump together and say "this
> must be here for the SoC to build and have minimal functionality" is one
> patch.  The changes that adds useful functionality is a patch each.

Well, the review would certainly be easier for me, if this was just
one patch, so I would gladly merge them.

>
>>   aspeed: Common configuration parameters for aspeed boards
>>   aspeed: Device Tree for ast2500 Eval Board
>>   aspeed: Configuration for ast2500 eval board
>
> Adding the ast2500 EVB would be another single patch.

Sounds good to me.

>
> --
> Tom



-- 
Maxim Sloyko